This repository was archived by the owner on May 29, 2019. It is now read-only.
refactor(tooltip): optimize positioning routine #4328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped position logic in a timeout to ensure the digest cycle always completes before positioning the popup. Also optimized when the calls to position the popup occur. Closes #4328
|
LGTM |
|
Hi, It looks like after this change popovers/tooltips started to 'flicker' when appearing. Cheers, |
|
Already fixed in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped position logic in a timeout to ensure the
digest cycle always completes before positioning
the popup. Also optimized when the calls to
position the popup occur.